feat(bindings/cpp): init the async support of C++ binding #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Oct 17, 2024
|
It's ready for review now : ) |
PragmaTwice
commented
Oct 17, 2024
Comment on lines
+46
to
+58
| auto path = "test_path"; | ||
| std::vector<uint8_t> data{1, 2, 3, 4, 5}; | ||
| cppcoro::sync_wait(op->write(path, data)); | ||
| auto res = cppcoro::sync_wait(op->read(path)); | ||
| for (size_t i = 0; i < data.size(); ++i) EXPECT_EQ(data[i], res[i]); | ||
|
|
||
| path = "test_path2"; | ||
| cppcoro::sync_wait([&]() -> cppcoro::task<void> { | ||
| co_await op->write(path, data); | ||
| auto res = co_await op->read(path); | ||
| for (size_t i = 0; i < data.size(); ++i) EXPECT_EQ(data[i], res[i]); | ||
| co_return; | ||
| }()); |
There was a problem hiding this comment.
A quick demo of async C++ binding.
4 tasks
|
https://crates.io/crates/cxx-async 0.1.2 has been released, let's move! |
|
Great. I'll continue on this PR and cxx-async in next few days. |
Xuanwo
approved these changes
Nov 16, 2024
|
Inviting @silver-ymz and @xyjixyjixyji to take another look. |
silver-ymz
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Great!
Cmake with a version greater than 3.24 may issue a warning.
CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FetchContent.cmake:1279 (message):
The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
not set. The policy's OLD behavior will be used. When using a URL
download, the timestamps of extracted files should preferably be that of
the time of extraction, otherwise code that depends on the extracted
contents might not be rebuilt if the URL changes. The OLD behavior
preserves the timestamps from the archive instead, but this is usually not
what you want. Update your project to the NEW behavior or specify the
DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
robustness issue.
Call Stack (most recent call first):
CMakeLists.txt:121 (FetchContent_Declare)
We can fix it in another PR, for example by adding the following to CmakeLists.txt
if (POLICY CMP0135)
cmake_policy(SET CMP0135 NEW)
endif ()
|
Thank you @silver-ymz for the review. Let's move!
Thank you for your review! Tracked at #5337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5194.
Rationale for this change
This PR initializes the async version of C++ binding.
What changes are included in this PR?
writeandreadmethodsAre there any user-facing changes?
Since
OPENDAL_ENABLE_ASYNCis off by default, so current users shouldn't feel the difference.