Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename public api create to create_dir #1512

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

suyanhanx
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

part of #1429

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
Copy link
Member Author

It seems like only the test_create_file_existing of WebDAV has failed.
Could you help me to take a look? @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Mar 8, 2023

It seems like only the test_create_file_existing of WebDAV has failed.

204 status code should be allowed, we can add this into https://github.com/datafuselabs/opendal/blob/main/src/services/webdav/writer.rs#L55

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented Mar 8, 2023

Great change, let's merge!

@Xuanwo Xuanwo merged commit 7bb7bef into apache:main Mar 8, 2023
@suyanhanx suyanhanx deleted the remove-create-for-file branch March 8, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants