Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/nodejs): Migrate to BDD test #1661

Merged
merged 3 commits into from
Mar 17, 2023
Merged

feat(bindings/nodejs): Migrate to BDD test #1661

merged 3 commits into from
Mar 17, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 17, 2023

No description provided.

@Xuanwo
feat(bindings/nodejs): Migrate to BDD test
0059d2c 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from ClSlaid and PsiACE March 17, 2023 09:13
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 17, 2023

cc @suyanhanx for reviewing.

@suyanhanx
Copy link
Member

🤣 You are moving fast!

suyanhanx
suyanhanx reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of them LGTM.

bindings/nodejs/tests/binding.js Show resolved Hide resolved
bindings/nodejs/package.json Show resolved Hide resolved
@Xuanwo
Address comments
d866003 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit cfb8db8 into main Mar 17, 2023
@Xuanwo Xuanwo deleted the bdd-js-binding branch March 17, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClSlaid ClSlaid ClSlaid approved these changes

@PsiACE PsiACE PsiACE approved these changes

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @suyanhanx @PsiACE @ClSlaid