Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/nodejs): Add generated index.d.ts #1664

Merged
merged 3 commits into from
Mar 17, 2023
Merged

feat(bindings/nodejs): Add generated index.d.ts #1664

merged 3 commits into from
Mar 17, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Mar 17, 2023 •
edited
Loading

close #1662

Patch napi-cli to append license header into index.d.ts.

@suyanhanx
chore(bindings/nodejs): commit index.d.ts
4a43b32 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
ci(docs): remove bindings/nodejs build step
c82d25a 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo Xuanwo changed the title Add index dts feat(bindings/nodejs): Add generated index.d.ts Mar 17, 2023
@suyanhanx suyanhanx changed the title feat(bindings/nodejs): Add generated index.d.ts feat(bindings/nodejs): Add index.d.ts Mar 17, 2023
@suyanhanx suyanhanx changed the title feat(bindings/nodejs): Add index.d.ts feat(bindings/nodejs): Add generated index.d.ts Mar 17, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Mar 17, 2023

Please merge the main branch with your current branch as we have enabled the license checker.

@Xuanwo Xuanwo mentioned this pull request Mar 17, 2023
Closed
@Xuanwo Xuanwo merged commit 1aae111 into apache:main Mar 17, 2023
@suyanhanx suyanhanx deleted the add-index-dts branch March 17, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Commit index.d.ts in repo
2 participants
@suyanhanx @Xuanwo