Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-1735: Operation Extension #1735

Merged
merged 6 commits into from
Mar 23, 2023
Merged

RFC-1735: Operation Extension #1735

merged 6 commits into from
Mar 23, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 23, 2023 •
edited
Loading

Addressing the feautres requested by:

@Xuanwo
RFC: Operation Extension
f6cd0a8 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title RFC: Operation Extension RFC-1735: Operation Extension Mar 23, 2023
@Xuanwo
Assign number
4dcabf6 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Update
32f4d1e 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 23, 2023

Also, cc @baszalmstra if you want to take a look.

@Xuanwo @suyanhanx
Update core/src/docs/rfcs/1735_operation_extension.md
2ff6f94 
Co-authored-by: Suyan <suyanhanx@gmail.com>
suyanhanx
suyanhanx approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ClSlaid
ClSlaid approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@ClSlaid ClSlaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo mentioned this pull request Mar 23, 2023
Closed
7 tasks
@Xuanwo
Update tracking issue
76cba4a 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix typo
ade885f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@baszalmstra
Copy link
Contributor

LGTM!

@Xuanwo Xuanwo merged commit ccd0017 into main Mar 23, 2023
@Xuanwo Xuanwo deleted the proposal-of-http-headers branch March 23, 2023 12:46
This was referenced Mar 23, 2023
Merged
Closed
@Xuanwo Xuanwo mentioned this pull request Apr 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@ClSlaid ClSlaid ClSlaid approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @baszalmstra @suyanhanx @ClSlaid