Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/ruby): add namespace #1745

Merged
merged 1 commit into from
Mar 24, 2023
Merged

feat(bindings/ruby): add namespace #1745

merged 1 commit into from
Mar 24, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 24, 2023

@PsiACE
feat(bindings/ruby): add namespace
5dbc998 
Signed-off-by: Chojan Shang <psiace@outlook.com>
@suyanhanx
Copy link
Member

May we add a step for test in CI?

@Xuanwo
Copy link
Member

Xuanwo commented Mar 24, 2023

May we add a step for test in CI?

We can do this in another PR.

@Xuanwo Xuanwo merged commit 593c031 into apache:main Mar 24, 2023
@PsiACE
Copy link
Member Author

PsiACE commented Mar 24, 2023

May we add a step for test in CI?

In fact, the CI for Ruby bindings now includes testing.

@PsiACE PsiACE deleted the module branch March 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PsiACE @suyanhanx @Xuanwo