-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tracing support via minitrace #175
Conversation
Yes, I think it's enough, for now, to only track |
We don't need to test the logic of BTW, How about adding a new env like |
I add this to env Curious where to load this env variables. Is it in the tests/behavior or in new function like service/s3::new() |
We load env via We will maintian a BTW, I think |
Great, let's merge this PR! |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
refer this issue
I want to confirm this function, minitrace has special macros for asynchronous and synchronous functions to implement span functions sent to jaeger via collector, we just want to track read, write, delete these functions?