Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oli): implement oli ls #1755

Merged
merged 1 commit into from
Mar 24, 2023
Merged

feat(oli): implement oli ls #1755

merged 1 commit into from
Mar 24, 2023

Conversation

knight42
Copy link
Contributor

@knight42 knight42 commented Mar 24, 2023

Fix #1740

Output:

$ ./target/debug/oli ls s3://prod/
20230310/
20230313/

$ ./target/debug/oli ls s3://prod/ -r
prod/20230310/material_asset.txt
prod/20230310/model_asset.txt
prod/20230313/material_asset.txt
prod/20230313/model_asset.txt

Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@knight42
Copy link
Contributor Author

@Xuanwo

OpenDAL has some magic internally, so all services will provide both scan and list support.

I have tried http and redis service, and it seems they don't support list

$ ./target/debug/oli ls ustcmirror://
Error: Unsupported (permanent) at list, context: { service: http } => operation is not supported

Am i missing sth?

@knight42 knight42 mentioned this pull request Mar 24, 2023
2 tasks
@Xuanwo
Copy link
Member

Xuanwo commented Mar 24, 2023

service that not support neither list not scan doesn't have this magic.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Xuanwo Xuanwo merged commit d2d56b3 into apache:main Mar 24, 2023
@knight42 knight42 deleted the feat/oli-ls branch March 24, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oli: implement oli ls (ols)
2 participants