Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/nodejs): Fix generated headers #1802

Merged
merged 3 commits into from
Mar 30, 2023
Merged

chore(bindings/nodejs): Fix generated headers #1802

merged 3 commits into from
Mar 30, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 30, 2023

No description provided.

@Xuanwo
chore(bindings/nodejs): Fix generated headers
5160f6c 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx March 30, 2023 07:48
@Xuanwo
Add check for format
303346f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

Let me have a try.

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 30, 2023

Let me have a try.

Welcome for better solution!

suyanhanx
suyanhanx reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

.github/workflows/bindings_nodejs.yml Show resolved Hide resolved
@Xuanwo
Fix typo
e0d1706 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 3488ec3 into main Mar 30, 2023
@Xuanwo Xuanwo deleted the fix-header branch March 30, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx