Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix build for nodejs binding on macos #1813

Merged
merged 7 commits into from
Mar 31, 2023
Merged

ci: Fix build for nodejs binding on macos #1813

merged 7 commits into from
Mar 31, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 31, 2023

No description provided.

@Xuanwo
ci: Fix build for nodejs binding on macos
7945475 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx March 31, 2023 03:17
@Xuanwo
Fix typo
4ecdee7 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix build
db73e8e 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 31, 2023

We should only include daily used commands in package.json. For other commands, we can use yarn run napi xxx directly and document them if necessary.

@suyanhanx
Copy link
Member

We should only include daily used commands in package.json. For other commands, we can use yarn run napi xxx directly and document them if necessary.

🤣 This is too simple.

@Xuanwo
Fix publish
7aa0763 
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

🤣 We should not run prepublishOnly on our local machine.

@Xuanwo
rollback changes
ccec582 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Remove comments
d9d49a0 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 31, 2023

cc @suyanhanx for final review.

suyanhanx
suyanhanx approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 8fe859a into main Mar 31, 2023
@Xuanwo Xuanwo deleted the fix-nodejs-build branch March 31, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx