Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3): allow users to specify storage_class #1854

Merged
merged 4 commits into from
Apr 5, 2023
Merged

feat(s3): allow users to specify storage_class #1854

merged 4 commits into from
Apr 5, 2023

Conversation

knight42
Copy link
Contributor

@knight42 knight42 commented Apr 5, 2023

Fix #1751

This PR adds storage_class option to OpWrite and enables users to specify default storage_class or override it when using s3 backend.

@knight42
feat(s3): allow users to specify storage_class
a99fe0d 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
knight42
knight42 commented Apr 5, 2023
View reviewed changes
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Apr 5, 2023 •
edited
Loading

adds storage_class option to OpWrite

storage_class should not be added into OpWrite. Because users can't write code without knowing what's service it is. This violates OpenDAL's VISION.

Refer to RFC-1735 for our current design.

@knight42
fix: OpWrite should be unaware of storage_class
9ce9412 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@knight42
style: make clippy happy about s3_put_object_request
4a862f1 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
Xuanwo
Xuanwo reviewed Apr 5, 2023
View reviewed changes
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
@knight42
refactor: rename to default_storage_class
5f070e8 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
Xuanwo
Xuanwo approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit eca0e95 into apache:main Apr 5, 2023
@knight42 knight42 deleted the feat/s3-storage-class branch April 5, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default_storage_class for services s3
2 participants
@knight42 @Xuanwo