Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix presign related unit tests #1910

Merged
merged 2 commits into from
Apr 11, 2023
Merged

fix: Fix presign related unit tests #1910

merged 2 commits into from
Apr 11, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 11, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 11, 2023

@suyanhanx Thanks for the quick review!

@suyanhanx
Copy link
Member

suyanhanx commented Apr 11, 2023

https://github.com/apache/incubator-opendal/blob/ab13bc78e416fad016d9804341f184d7f2f5442f/core/src/services/s3/core.rs#L124

Could also fix this typo~ durtion -> duration

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit f779d82 into main Apr 11, 2023
@Xuanwo Xuanwo deleted the fix-unit-tests branch April 11, 2023 14:49
wcy-fdu pushed a commit to wcy-fdu/opendal that referenced this pull request Apr 12, 2023
* fix: Fix presign related unit tests

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix typo

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants