-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Feel relax in community and don't hurry #1987
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Some PRs will depend on other PRs. It may wait for over 90 days without any replies.
Close PRs will make potential contributors unhappy. Maybe they won't create a new PR anymore. Kenji Mouri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This rule has been removed. |
Signed-off-by: Xuanwo <github@xuanwo.io>
The issue or PR that blocking the progress should be addressed in the PR. We should avoid long unresponsed PRs, after all.
Indeed, but I think closing PRs with detailed, sincere explaination, is acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It seems you are not suffering from the long code review. (Many years ago, I contribute something to OpenSSL, they use one year and a half reviewed my PR. It makes me PTSD and I don't want to make PR to others anymore for several years, until LVGL's author give me some warm.) Kenji Mouri |
Thanks for sharing, but I think this case is a bit different from OpenDAL. OpenDAL's maintainer make sure that all PR get reviewed inside 24 hours. Our contributor never need to wait for more one day. Anyway, we have changed the policy and will not close stale PR anymore. Thanks again for the review. |
Take it easy. No one can give a guarantee with a hundred percent sure. Life is filled with uncertainty.🤣 |
Short version: How about apply it to PRs that is inactive, and with no addition information about the inactivity? This should be acceptable.
I strongly support the idea of closing long no respond PRs because I've once created such one. But I do agree closing Those inactive PRs often comes with:
OpenDAL is not very complex and most of the PR is quite straight forward. Our PR got quick review and response from warm-hearted developers. How about apply it to PRs that is inactive, and with no addition information about the inactivity? This should be acceptable. |
Let's enjoy playing inside OpenDAL! |
No description provided.