Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Feel relax in community and don't hurry #1987

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 14, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title docs: Relax in community and don't hurry docs: Feel relax in community and don't hurry Apr 14, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@MouriNaruto
Copy link

If a PR remains inactive for 90 days, it will be closed.

Some PRs will depend on other PRs. It may wait for over 90 days without any replies.

It is important to note that closing a PR does not necessarily mean rejection.

Close PRs will make potential contributors unhappy. Maybe they won't create a new PR anymore.

Kenji Mouri

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 14, 2023

Some PRs will depend on other PRs. It may wait for over 90 days without any replies.

This rule has been removed.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
@ClSlaid
Copy link
Contributor

ClSlaid commented Apr 14, 2023

Some PRs will depend on other PRs. It may wait for over 90 days without any replies.

The issue or PR that blocking the progress should be addressed in the PR. We should avoid long unresponsed PRs, after all.

Close PRs will make potential contributors unhappy. Maybe they won't create a new PR anymore.

Indeed, but I think closing PRs with detailed, sincere explaination, is acceptable.

Copy link

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MouriNaruto
Copy link

The issue or PR that blocking the progress should be addressed in the PR. We should avoid long unresponsed PRs, after all.

It seems you are not suffering from the long code review. (Many years ago, I contribute something to OpenSSL, they use one year and a half reviewed my PR. It makes me PTSD and I don't want to make PR to others anymore for several years, until LVGL's author give me some warm.)

Kenji Mouri

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 14, 2023

It seems you are not suffering from the long code review. (Many years ago, I contribute something to OpenSSL, they use one year and a half reviewed my PR.

Thanks for sharing, but I think this case is a bit different from OpenDAL. OpenDAL's maintainer make sure that all PR get reviewed inside 24 hours. Our contributor never need to wait for more one day.

Anyway, we have changed the policy and will not close stale PR anymore.

Thanks again for the review.

@suyanhanx
Copy link
Member

OpenDAL's maintainer make sure that all PR get reviewed inside 24 hours. Our contributor never need to wait for more one day.

Take it easy. No one can give a guarantee with a hundred percent sure. Life is filled with uncertainty.🤣

@ClSlaid
Copy link
Contributor

ClSlaid commented Apr 14, 2023

Short version:

How about apply it to PRs that is inactive, and with no addition information about the inactivity? This should be acceptable.


Indeed, but I think closing PRs with detailed, sincere explaination, is acceptable.

I strongly support the idea of closing long no respond PRs because I've once created such one.

But I do agree closing not responded PRs is quite too strict, maybe inactive PR is better.

Those inactive PRs often comes with:

  • stale or unrelated changes:
    for developers not familiar with git, some stale or unrelated changes may present in the PR, making review hard and could break the code base. This comes more severe when the code base is rapidly evolving with features and fixes. Some important fixes may be incorrectly shadowed by those stale and unrelated changes.
  • Inconsistent changes:
    open source contributors are seldom working full time on PRs, this may lead to inconsistent changes and bugs.

OpenDAL is not very complex and most of the PR is quite straight forward. Our PR got quick review and response from warm-hearted developers.

How about apply it to PRs that is inactive, and with no addition information about the inactivity? This should be acceptable.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 14, 2023

Let's enjoy playing inside OpenDAL!

@Xuanwo Xuanwo merged commit 9cd7dd2 into main Apr 14, 2023
@Xuanwo Xuanwo deleted the relax-and-have-fun branch April 14, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants