Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add oss if-none-match support #1997

Merged
merged 4 commits into from
Apr 14, 2023
Merged

feat: add oss if-none-match support #1997

merged 4 commits into from
Apr 14, 2023

Conversation

thorseraq
Copy link
Contributor

@thorseraq thorseraq commented Apr 14, 2023 •
edited by Xuanwo
Loading

Fix #1977

Xuanwo
Xuanwo reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Mostly LGTM.

core/src/services/oss/core.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Member

Xuanwo commented Apr 14, 2023

The only thing left here is to make our CI happy! Please try running cargo fmt to make code foramtted.

@Xuanwo Xuanwo merged commit b182d1e into apache:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oss: Add if-none-match support
2 participants
@thorseraq @Xuanwo