Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add OpenTelemetry Trace Layer #2001

Merged
merged 22 commits into from
Apr 18, 2023
Merged

feat: Add OpenTelemetry Trace Layer #2001

merged 22 commits into from
Apr 18, 2023

Conversation

teckick
Copy link
Contributor

@teckick teckick commented Apr 14, 2023 •
edited
Loading

Fix #1933

@teckick teckick marked this pull request as draft April 14, 2023 17:17
teckick
teckick commented Apr 14, 2023
View reviewed changes
core/src/layers/oteltrace.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Apr 16, 2023 •
edited
Loading

By the way, maybe we can add trace support first? metrics could be added in next PR.

@Xuanwo Xuanwo changed the title Add OpenTelemetry metrics and trace feat: Add OpenTelemetry Trace Layer Apr 17, 2023
@teckick teckick marked this pull request as ready for review April 18, 2023 09:37
@teckick
Copy link
Contributor Author

teckick commented Apr 18, 2023

Mostly finished, but OtelTraceWrapper part is not implemented. I'm not sure how to instrument the poll_read() function. Could you please give some advise?

Xuanwo
Xuanwo approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

core/Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Apr 18, 2023

Mostly finished, but OtelTraceWrapper part is not implemented. I'm not sure how to instrument the poll_read() function. Could you please give some advise?

I guess we need to pass a span to wrapper and use it's context as new span's parent.

Xuanwo
Xuanwo reviewed Apr 18, 2023
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 787c3c8 into apache:main Apr 18, 2023
@teckick teckick deleted the dev-otel branch April 18, 2023 14:02
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add opentelemetry trace/metrics support
2 participants
@teckick @Xuanwo