Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add If-Match Support for OpRead, OpWrite, OpStat #2017

Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat: add If-Match Support for OpRead, OpWrite, OpStat #2017

merged 1 commit into from
Apr 17, 2023

Conversation

STRRL
Copy link
Contributor

@STRRL STRRL commented Apr 17, 2023

close #1966

This PR introduces if_match: Option<String> for structs OpRead, OpWrite and OpStat

@STRRL
feat: add If-Match Support for OpRead, OpWrite, OpStat
f791eeb 
Signed-off-by: STRRL <im@strrl.dev>
Xuanwo
Xuanwo reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo marked this pull request as ready for review April 17, 2023 08:48
@STRRL
Copy link
Contributor Author

STRRL commented Apr 17, 2023

This PR only introduces options in Op(s) without service implementation.

I noticed that lots of contributors want to build the implementation to popular backends, so this PR just opened without implementation for not blocking their works.

@Xuanwo Xuanwo merged commit bae04af into apache:main Apr 17, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Apr 17, 2023

I noticed that lots of contributors want to build the implementation to popular backends, so this PR just opened without implementation for not blocking their works.

Thank you very much! I apologize for the pressure. We will work on improving our task assignments in the future.

@STRRL
Copy link
Contributor Author

STRRL commented Apr 17, 2023

I noticed that lots of contributors want to build the implementation to popular backends, so this PR just opened without implementation for not blocking their works.

Thank you very much! I apologize for the pressure. We will work on improving our task assignments in the future.

That's OK. I am REALLY pleased to see many active contributors in opendal community. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: Add if-match support in OpRead/OpWrite/OpStat
2 participants
@STRRL @Xuanwo