Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add behavioral test for Write::abort #2018

Merged
merged 3 commits into from
Apr 17, 2023
Merged

feat: add behavioral test for Write::abort #2018

merged 3 commits into from
Apr 17, 2023

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 17, 2023

This PR:

  • adds abort API for opendal::types::writer::Writer
  • adds behavioral test for abort

@v0y4g3r v0y4g3r force-pushed the feat/behavioral-test-for-abort branch from 8fc9b25 to b0c4d0c Compare April 17, 2023 09:49
Xuanwo
Xuanwo approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit a040f1d into apache:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v0y4g3r @Xuanwo