Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add size check for sized writer #2038

Merged
merged 3 commits into from
Apr 19, 2023
Merged

feat: Add size check for sized writer #2038

merged 3 commits into from
Apr 19, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 19, 2023

This PR adds a size check for writer at complete layer.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx April 19, 2023 12:10
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

core/src/types/writer.rs Show resolved Hide resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 93dfb29 into main Apr 19, 2023
@Xuanwo Xuanwo deleted the add-docs-and-checks branch April 19, 2023 12:13
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants