Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use typos action to run it #2054

Closed
wants to merge 1 commit into from
Closed

ci: Use typos action to run it #2054

wants to merge 1 commit into from

Conversation

hezhizhen
Copy link
Contributor

  1. use the official action to replace manually downloading and running it
  2. upgrade to 1.14.8

@Xuanwo
Copy link
Member

Xuanwo commented Apr 21, 2023

image

Thanks for your PR! But as mentioned in the image, the ASF has a strong policy on the actions that we can use. So I prefer to keep the current way instead of adding new actions.

Maybe it's a good idea to just upgrade typos version?

@hezhizhen
Copy link
Contributor Author

image

Thanks for your PR! But as mentioned in the image, the ASF has a strong policy on the actions that we can use. So I prefer to keep the current way instead of adding new actions.

Maybe it's a good idea to just upgrade typos version?

Oh, I see.

@hezhizhen
Copy link
Contributor Author

See #2055 @Xuanwo

@hezhizhen hezhizhen closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hezhizhen @Xuanwo