Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/nodejs): update package.json repository info #2078

Merged
merged 2 commits into from
Apr 23, 2023
Merged

chore(bindings/nodejs): update package.json repository info #2078

merged 2 commits into from
Apr 23, 2023

Conversation

imp2002
Copy link
Contributor

@imp2002 imp2002 commented Apr 23, 2023

Fix: #2075

@imp2002 imp2002 requested a review from suyanhanx as a code owner April 23, 2023 06:11
@Xuanwo
Copy link
Member

Xuanwo commented Apr 23, 2023

I believe the real problem happened here: https://github.com/apache/incubator-opendal/blob/main/bindings/nodejs/npm/darwin-arm64/package.json

@suyanhanx
Copy link
Member

suyanhanx commented Apr 23, 2023 •
edited
Loading

You may need to update repo URL into the sub modules in binginds/nodejs/npm/.

suyanhanx
suyanhanx approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 85dcff7 into apache:main Apr 23, 2023
@Xuanwo Xuanwo mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release: Nodejs release failed for 422 Unprocessable Entity
3 participants
@imp2002 @Xuanwo @suyanhanx