Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/azblob): Add supporting presign #2120

Merged
merged 5 commits into from
Apr 26, 2023
Merged

feat(services/azblob): Add supporting presign #2120

merged 5 commits into from
Apr 26, 2023

Conversation

silver-ymz
Copy link
Member

@silver-ymz silver-ymz commented Apr 25, 2023 •
edited
Loading

Close #2118

@Xuanwo
Copy link
Member

Xuanwo commented Apr 25, 2023

Hi, please update your branch with main~

@Xuanwo Xuanwo marked this pull request as draft April 25, 2023 13:00
@silver-ymz
Copy link
Member Author

The tests failed because Source: SAS token is required for query signing.
https://github.com/apache/incubator-opendal/blob/8fc4f895ee84324746daaf6a8bc5483b92f04074/.github/workflows/service_test_azblob.yml#L72
And the tests only set shared key, not shared access signature.

https://github.com/Xuanwo/reqsign/blob/089a4a1e83348b11d06c88fb130ee4fae6dd6c86/src/azure/storage/signer.rs#L72
In reqsign, it does not implement shared key signing for query.

So are the tests failure a problem with the test setup?

Xuanwo
Xuanwo reviewed Apr 25, 2023
View reviewed changes
core/src/services/azblob/backend.rs Outdated Show resolved Hide resolved
core/src/services/azblob/backend.rs Outdated Show resolved Hide resolved
@silver-ymz silver-ymz marked this pull request as ready for review April 25, 2023 15:27
@silver-ymz silver-ymz requested a review from Xuanwo April 26, 2023 00:40
Xuanwo
Xuanwo approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit 5376801 into apache:main Apr 26, 2023
@silver-ymz silver-ymz deleted the presign-azblob branch April 26, 2023 03:50
@Xuanwo Xuanwo mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add supporting presign for azblob
2 participants
@silver-ymz @Xuanwo