Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/s3): Return error if credential load fail instead skip #2233

Merged
merged 4 commits into from
May 8, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 8, 2023

Fix #2232

Xuanwo added 2 commits May 8, 2023 15:48
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo added 2 commits May 8, 2023 15:51
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx May 8, 2023 07:58
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xuanwo Xuanwo merged commit 7d5f096 into main May 8, 2023
@Xuanwo Xuanwo deleted the fix-s3-cred branch May 8, 2023 08:07
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
…pache#2233)

* fix(services/s3): Return error if credential load fail instead skip

Signed-off-by: Xuanwo <github@xuanwo.io>

* set_temporary for reqsign error

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix OPENDAL_S3_ALLOW_ANONYMOUS

Signed-off-by: Xuanwo <github@xuanwo.io>

* Bump MSRV to 1.65

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: S3 could send Anonymous request if credentail load failed
2 participants