Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add assert for public types to ensure Send + Sync #2237

Merged
merged 1 commit into from
May 8, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 8, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title feat: Add assert for public types to make sure Send + Sync feat: Add assert for public types to ensure Send + Sync May 8, 2023
@Xuanwo Xuanwo requested a review from suyanhanx May 8, 2023 12:29
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 Interesting. Thanks.

@Xuanwo Xuanwo merged commit 7ce2371 into main May 8, 2023
@Xuanwo Xuanwo deleted the make-sure-writer-is-sync branch May 8, 2023 12:31
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants