Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/python): Enable abi3 to avoid building on different python version #2255

Merged
merged 1 commit into from
May 11, 2023

Conversation

frostming
Copy link
Contributor

@frostming frostming commented May 11, 2023

Fixes #2252

Signed-off-by: Frost Ming me@frostming.com

chrono::Duration <-> pyo3::types::PyDelta is not availiable under Py_Limited_API, so I switch it to float(in seconds) instead.

…ython version

Fixes apache#2252

Signed-off-by: Frost Ming <me@frostming.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 8ef38ac into apache:main May 11, 2023
@frostming frostming deleted the frostming/issue2252 branch May 11, 2023 11:31
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bindings/python: Enable abi3 to avoid building on different python version
2 participants