Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/webdav): support redirection when get 302/307 response during read operation #2256

Merged
merged 44 commits into from
May 30, 2023
Merged

feat(services/webdav): support redirection when get 302/307 response during read operation #2256

merged 44 commits into from
May 30, 2023

Conversation

Gnosnay
Copy link
Contributor

@Gnosnay Gnosnay commented May 11, 2023 •
edited
Loading

related issue: #2146

Xuanwo
Xuanwo reviewed May 16, 2023
View reviewed changes
.github/workflows/service_test_webdav.yml Outdated Show resolved Hide resolved
core/src/services/webdav/backend.rs Outdated Show resolved Hide resolved
core/src/services/webdav/backend.rs Outdated Show resolved Hide resolved
@dtretyakov
Copy link

@Yansongsongsong are you still working on addressing review comments or you have no time?

@Gnosnay
Copy link
Contributor Author

Gnosnay commented May 27, 2023

@Yansongsongsong are you still working on addressing review comments or you have no time?

@dtretyakov hi i am still working on that. i may push my change tmr. sorry for late

@Gnosnay
Copy link
Contributor Author

Gnosnay commented May 28, 2023

hi @Xuanwo , sorry for late. have refactored according to the review. please have one look at this. thank you

@Xuanwo
Copy link
Member

Xuanwo commented May 30, 2023

hi @Xuanwo , sorry for late. have refactored according to the review. please have one look at this. thank you

Sorry for miss this comment, I will take a look today.

Xuanwo
Xuanwo approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo
Copy link
Member

Xuanwo commented May 30, 2023

Please resolve the conflict so that we can merge this PR in!

@Gnosnay
Copy link
Contributor Author

Gnosnay commented May 30, 2023

Please resolve the conflict so that we can merge this PR in!

@Xuanwo conflicts resolved. thank you for mentoring.

@Xuanwo
Copy link
Member

Xuanwo commented May 30, 2023

Hi, @Yansongsongsong please update branch and try again. Sorry for our fault.

@Xuanwo Xuanwo merged commit fc7207e into apache:main May 30, 2023
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Closed
@suyanhanx
Copy link
Member

I've updated it for you. Thanks for your hard work!

@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
Merged
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gnosnay @dtretyakov @Xuanwo @suyanhanx