-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Unify capabilities list for kv services #2257
Conversation
Yes, they are by design. We removed scan in previous refactor.
Not. They can't be migrated to typed_kv since they can't store a typed_kv::Value with zero cost.
No, we don't do refactor like this kind. Current code structure is clean and easy to understand. |
@Xuanwo Thanks for reply! I reverted change of
Any material or discussion about the design? |
Thank you for fixing this! Wish it is help to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In the very first, I want to migrate
sled
/rocksdb
services totyped_kv
. But I foundtyped_kv
has its own data schema (metadata
+value
), it seems would break loading and writing of existed data? Discussion is required here.Then I found the type
crate::Capability
doesn't havescan
flag, is this intentional result or deliberate design?Then for this PR,
scan
flag to generalCapability
Notes:
cargo test
passed locally.scan
flag for those services capable withscan
haven't set totrue
yet.Further discussions:
typed_kv
migration forsled
/rocksdb
/memorycache
/redis
BlockCapability
; 2.ObjectCapability
, 3.KvCapability
This's my first PR for OpenDAL 😀 Please check more in details.
Thanks for your efforts!
Sincerely,
Lanqing