Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(binding/java): build, async and docs #2276

Merged
merged 23 commits into from
May 22, 2023
Merged

refactor(binding/java): build, async and docs #2276

merged 23 commits into from
May 22, 2023

Conversation

tisonkun
Copy link
Member

No description provided.

@tisonkun
refactor: java bindings
0cd8b5a 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
update rust code
8baa653 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
fix build and test
ba8efb9 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
pass tests
4162245 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
simplify threadlocal
7e0b9ba 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
simplify dispose
7b9b65e 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Update README.md doc
1bbaa8a 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
need not invocation feature
a5d43a5 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
cargo clippy
f8aa2dc 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
cargo fmt
df792fc 
Signed-off-by: tison <wander4096@gmail.com>
@suyanhanx
Copy link
Member

Hi, tison. Thank you for the PR!
Could you please provide a more detailed explanation of the changes in the desc? Since we are not particularly familiar with Java.

tisonkun
tisonkun commented May 20, 2023
View reviewed changes
Copy link
Member Author

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suyanhanx comment inline.

bindings/java/README.md Show resolved Hide resolved
bindings/java/pom.xml Show resolved Hide resolved
bindings/java/pom.xml Show resolved Hide resolved
bindings/java/src/main/java/org/apache/opendal/Metadata.java Show resolved Hide resolved
bindings/java/src/main/java/org/apache/opendal/Metadata.java Show resolved Hide resolved
bindings/java/src/main/java/org/apache/opendal/NativeObject.java Show resolved Hide resolved
bindings/java/src/main/java/org/apache/opendal/exception/ODException.java Outdated Show resolved Hide resolved
bindings/java/src/main/java/org/apache/opendal/exception/ODException.java Show resolved Hide resolved
bindings/java/src/lib.rs Show resolved Hide resolved
bindings/java/src/lib.rs Show resolved Hide resolved
@tisonkun
ci sync workflow
1dd3da2 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
use thread local of raw ptr to JNIEnv
c8a3be0 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
test: errors should exhausted and matched
c216fab 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
streamline a bit the code
7005edf 
Signed-off-by: tison <wander4096@gmail.com>
ShadowySpirits
ShadowySpirits approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@ShadowySpirits ShadowySpirits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xuanwo
Xuanwo reviewed May 22, 2023
View reviewed changes
bindings/java/Cargo.toml Outdated Show resolved Hide resolved
bindings/java/Cargo.toml Outdated Show resolved Hide resolved
core/src/types/error.rs Outdated Show resolved Hide resolved
core/src/types/error.rs Outdated Show resolved Hide resolved
@tisonkun
rename opendaljni to opendal-java
f2c36f1 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
pass error code as string
59b874f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
revert core lib changes
294c72e 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Revert "cargo clippy"
b5d8f2a 
This reverts commit f8aa2dc.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
add test_opendal_error_exhausted in the rust side
af5e1d0 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

@Xuanwo Updated.

Xuanwo
Xuanwo reviewed May 22, 2023
View reviewed changes
bindings/java/src/lib.rs Outdated Show resolved Hide resolved
core/Cargo.toml Outdated Show resolved Hide resolved
@tisonkun
simplify code with Operator::viamap
7dbd5f5 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
style
7ad2e64 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
tidy
3208baf 
Signed-off-by: tison <wander4096@gmail.com>
Xuanwo
Xuanwo approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 1ea32b6 into apache:main May 22, 2023
@tisonkun tisonkun deleted the refactor-java-bindings branch May 22, 2023 11:20
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Merged
@tisonkun tisonkun mentioned this pull request May 24, 2023
Closed
@tisonkun tisonkun mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadowySpirits ShadowySpirits ShadowySpirits approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisonkun @suyanhanx @Xuanwo @ShadowySpirits