-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(bindings/C): The documentation for OpenDAL C binding #2373
Conversation
Related #2321 This is relative a big PR but almost w/o funcationality changes. |
It seems the CI is failing on the files generated by doxygen, is there any workaround? |
You may not commit them. We just need to generate those docs in the CI job and deploy them as a part of our site. FYI: |
Sure |
I have updated on the github action, I am not an expert on it so PTAL ❤️ |
Another problem is that the licence header CI requires C files to be started with
However, that would make the header part of the documentation (in the first struct appears in the doc). Therefore I change it to
But this cannot pass the licence header check. |
cc @tisonkun |
I know for this part. Perhaps I can change the default in the hawkeye core later. For now, you can add the following config to the [mapping.SLASHSTAR_STYLE]
extensions = ["c", "h"] For changes upstream, perhaps something like this one korandoru/hawkeye@33e482f |
I have a simple question, why does this place still support memory scheme? Other schemes should also have similar methods, which should be easy to add. |
Thanks for pointing it out! 👍 This is indeed a problem. |
Yes, we can remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This PR uses
doxygen
to generate documentations for C binding.Developers could call
make doc
to generate documentations in./docs/doxygen/html/index.html
.The documentations in the Rust code for C binding now uses the doxygen style.