Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: service doc for s3 #2376

Merged
merged 4 commits into from
May 31, 2023
Merged

docs: service doc for s3 #2376

merged 4 commits into from
May 31, 2023

Conversation

suyanhanx
Copy link
Member

This PR adds docs for s3.

For better display on the site and anchor availability, I adjusted the title levels of the updated documents.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review May 31, 2023 06:52
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks for the doc!

core/src/services/s3/compatible_services.md Show resolved Hide resolved
website/docs/services/s3.mdx Show resolved Hide resolved
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 174533f into apache:main May 31, 2023
@suyanhanx suyanhanx deleted the sfs branch May 31, 2023 07:38
@suyanhanx suyanhanx mentioned this pull request May 31, 2023
29 tasks
@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants