Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blocking operator): add remove_all api #2449

Merged
merged 8 commits into from
Jun 21, 2023
Merged

feat(blocking operator): add remove_all api #2449

merged 8 commits into from
Jun 21, 2023

Conversation

infdahai
Copy link
Contributor

@infdahai infdahai commented Jun 11, 2023 •
edited
Loading

close #2439

@infdahai
add remove_all for blocking operator
51f36a0 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
update comment
e0c9bd8 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
add remove_one and remove_all in behavior test
6f63245 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
fix clippy
f3e26ac 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
Copy link
Contributor Author

do we range the vector to call remove_via for implementing remove?

Xuanwo
Xuanwo reviewed Jun 12, 2023
View reviewed changes
core/src/types/operator/blocking_operator.rs Outdated Show resolved Hide resolved
core/src/types/operator/blocking_operator.rs Outdated Show resolved Hide resolved
core/src/types/operator/blocking_operator.rs Outdated Show resolved Hide resolved
@infdahai
Copy link
Contributor Author

Dose my code cause the CI fails?

@Xuanwo
Copy link
Member

Xuanwo commented Jun 21, 2023

Dose my code cause the CI fails?

Seems not related, please ignore.

Xuanwo
Xuanwo approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit e2070d0 into apache:main Jun 21, 2023
@infdahai infdahai deleted the remove_all_block branch June 21, 2023 08:01
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement remove and remove_all for blocking operator
3 participants
@infdahai @Xuanwo @xyjixyjixyji