Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/haskell): support stat #2504

Merged
merged 4 commits into from
Jun 21, 2023
Merged

feat(bindings/haskell): support stat #2504

merged 4 commits into from
Jun 21, 2023

Conversation

silver-ymz
Copy link
Member

Update:

  • export Metadata, BytesContentRange, EntryMode
  • support stat for haskell bindings

The memory service only supports some metadata. Some parts of metadata, such as cache control, last modified time cannot be covered for testing. Should we concern about it?

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
bindings/haskell/haskell-src/OpenDAL.hs Outdated Show resolved Hide resolved
bindings/haskell/haskell-src/OpenDAL.hs Outdated Show resolved Hide resolved
bindings/haskell/haskell-src/OpenDAL.hs Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Jun 21, 2023

The memory service only supports some metadata. Some parts of metadata, such as cache control, last modified time cannot be covered for testing. Should we concern about it?

That's Ok. There is no services that provide all metadata.

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit b50d7f0 into apache:main Jun 21, 2023
@silver-ymz silver-ymz deleted the feat/haskell-stat branch June 21, 2023 08:15
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants