Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adapters-kv): add rename and copy support to non typed kv adapters #2515

Merged
merged 8 commits into from
Jun 23, 2023
Merged

feat(adapters-kv): add rename and copy support to non typed kv adapters #2515

merged 8 commits into from
Jun 23, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Jun 23, 2023

as same as #2513

@oowl
feat(adapters-kv): update kv base service doc
7cd291d 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2023

Please update https://github.com/apache/incubator-opendal/blob/f7e9d5aaee357f9e37c9c2c87c660c78289663c0/core/src/raw/adapters/typed_kv/backend.rs#L65 and https://github.com/apache/incubator-opendal/blob/f7e9d5aaee357f9e37c9c2c87c660c78289663c0/core/src/raw/adapters/kv/backend.rs#L69

@oowl
feat(adapters-kv): fix code
04334be 
Signed-off-by: owl <ouyangjun1999@gmail.com>
oowl added 2 commits June 23, 2023 13:02
@oowl
feat(adapters-kv): add capability field
4235d01 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(adapters-kv): fix code
3e5901d 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the feat/kv-adapters-rename-and-copy-II branch from 3e5901d to 251c5b5 Compare June 23, 2023 05:13
@oowl
feat(adapters-kv): fix code
9fb9638 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the feat/kv-adapters-rename-and-copy-II branch from 251c5b5 to 9fb9638 Compare June 23, 2023 05:22
Xuanwo
Xuanwo approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

oowl added 2 commits June 23, 2023 13:26
@oowl
feat(adapters-kv): fix code
b99d056 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
feat(adapters-kv): fix code
857520e 
Signed-off-by: owl <ouyangjun1999@gmail.com>
@Xuanwo Xuanwo merged commit 047e054 into apache:main Jun 23, 2023
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oowl @Xuanwo