Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(binding/lua): add luarocks package manager support #2558

Merged
merged 8 commits into from
Jun 30, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Jun 27, 2023

No description provided.

oowl added 2 commits June 28, 2023 01:52
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl
Copy link
Member Author

oowl commented Jun 27, 2023

╰─$ luarocks make --local

lua-opendal 0.1.0-1 depends on lua >= 5.1 (5.4-1 provided by VM)
lua-opendal 0.1.0-1 depends on luarocks-build-rust-mlua (0.1.0-1 installed)
    Finished release [optimized] target(s) in 0.11s

Error: Build error: Failed installing target/release/libopendal.so in /home/ouyang/.luarocks/lib/luarocks/rocks-5.4/lua-opendal/0.1.0-1/lib/opendal.so: target/release/libopendal.so: No such file or directory

build error because the opendal directory structure of a complex can't find the right cargo target binary files, I have created a pull request to upstream to try to fix this. So this PR will hold for wating mlua-rs/luarocks-build-rust-mlua#1 is merged and released.

@oowl oowl marked this pull request as draft June 27, 2023 18:20
oowl added 2 commits June 28, 2023 02:51
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
bindings/lua/Cargo.toml Outdated Show resolved Hide resolved
bindings/lua/README.md Outdated Show resolved Hide resolved
bindings/lua/lopendal-0.1.0-1.rockspec Outdated Show resolved Hide resolved
@oowl
Copy link
Member Author

oowl commented Jun 29, 2023

And I can not run cargo clippy --all-targets --all-features normal, because mlua need some features that can not be enabled in same time, these features are mutex, will be provided for mlua rocks build. Is anything another workaround for this? @Xuanwo

╰─$ cargo clippy --all-targets --all-features --workspace -- -D warnings                                                                                                                                                                                    16 ↵
    Checking serde_json v1.0.94
    Checking url v2.3.1
   Compiling openssl v0.10.47
    Checking openssl-sys v0.9.82
    Checking hyper v0.14.25
    Checking vec-strings v0.4.8
   Compiling native-tls v0.2.11
    Checking triomphe v0.1.8
    Checking serde_urlencoded v0.7.1
    Checking ssh_format_error v0.1.0
   Compiling librocksdb-sys v0.11.0+8.1.1
    Checking ssri v9.0.0
    Checking hdfs-sys v0.2.0
    Checking uuid v1.3.0
    Checking bincode v1.3.3
    Checking quick-xml v0.28.1
    Checking quick-xml v0.27.1
    Checking clap v4.2.5
    Checking serde_spanned v0.6.1
    Checking ssh_format v0.14.1
    Checking hdrs v0.2.0
    Checking openssh-sftp-protocol-error v0.1.0
    Checking concurrent_arena v0.1.7
    Checking mini-moka v0.10.0
    Checking toml_datetime v0.6.1
   Compiling tempfile v3.4.0
    Checking moka v0.10.0
    Checking openssh-sftp-error v0.3.1
    Checking openssh-sftp-protocol v0.24.0
    Checking madsim v0.2.21
   Compiling toml v0.5.11
    Checking trust-dns-proto v0.22.0
    Checking redis v0.22.3
    Checking toml_edit v0.19.7
    Checking serde_path_to_error v0.1.11
    Checking serde_qs v0.8.5
   Compiling mlua v0.8.9
    Checking openssh-sftp-client-lowlevel v0.5.1
    Checking jsonwebtoken v8.3.0
error: You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau
  --> /home/ouyang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mlua-0.8.9/build/main.rs:66:5
   |
66 | /     compile_error!(
67 | |         "You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau"
68 | |     );
   | |_____^

error: You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau
  --> /home/ouyang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mlua-0.8.9/build/main.rs:79:5
   |
79 | /     compile_error!(
80 | |         "You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau"
81 | |     );
   | |_____^

error: You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau
  --> /home/ouyang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mlua-0.8.9/build/main.rs:87:5
   |
87 | /     compile_error!(
88 | |         "You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau"
89 | |     );
   | |_____^

error: You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau
  --> /home/ouyang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mlua-0.8.9/build/main.rs:92:5
   |
92 | /     compile_error!(
93 | |         "You can enable only one of the features: lua54, lua53, lua52, lua51, luajit, luajit52, luau"
94 | |     );
   | |_____^

@oowl oowl marked this pull request as ready for review June 29, 2023 17:29
@oowl oowl force-pushed the chore/lua-bindings-rocks branch 2 times, most recently from 4bf929b to 3d08f88 Compare June 29, 2023 17:52
bindings/lua/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the chore/lua-bindings-rocks branch 2 times, most recently from a43737a to 745cd7a Compare June 30, 2023 05:42
bindings/lua/Cargo.toml Outdated Show resolved Hide resolved
bindings/lua/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl force-pushed the chore/lua-bindings-rocks branch from 745cd7a to 6f03d41 Compare June 30, 2023 05:50
Signed-off-by: owl <ouyangjun1999@gmail.com>
@oowl oowl requested a review from Xuanwo June 30, 2023 05:58
@Xuanwo Xuanwo changed the title chore(binding/lua): add luarocks package manager support ci(binding/lua): add luarocks package manager support Jun 30, 2023
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, thanks a lot for your hard work!

.github/workflows/bindings_lua.yml Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your hard work!

@Xuanwo Xuanwo merged commit 6d8aa3a into apache:main Jun 30, 2023
21 checks passed
ClSlaid added a commit to ClSlaid/opendal that referenced this pull request Jul 14, 2023
* feat(binding/lua): add rename and create_dir operator function by @oowl in apache#2564
* feat(services/azblob): support sink by @suyanhanx in apache#2574
* feat(services/gcs): support sink by @suyanhanx in apache#2576
* feat(services/oss): support sink by @suyanhanx in apache#2577
* feat(services/obs): support sink by @suyanhanx in apache#2578
* feat(services/cos): impl sink by @suyanhanx in apache#2587
* feat(service): Support stat for Dropbox by @Zheaoli in apache#2588
* feat(services/dropbox): impl create_dir and polish error handling by @suyanhanx in apache#2600
* feat(services/dropbox): Implement refresh token support by @Xuanwo in apache#2604
* feat(service/dropbox): impl batch delete by @suyanhanx in apache#2606
* feat(CI): set Kvrocks test for service redis by @suyanhanx in apache#2613
* feat(core): object versioning APIs by @suyanhanx in apache#2614
* feat(oay): actually read configuration from `oay.toml` by @messense in apache#2615
* feat(services/webdav): impl sink by @suyanhanx in apache#2622
* feat(services/fs): impl Sink for Fs by @Ji-Xinyou in apache#2626
* feat(core): impl `delete_with` on blocking operator by @suyanhanx in apache#2633
* feat(bindings/C): add support for list in C binding by @Ji-Xinyou in apache#2448
* refactor(core): Add ErrorKind InvalidInput to indicate users input error by @dqhl76 in apache#2637
* fix(doc): fix codeblock rendering by @xxchan in apache#2592
* fix(service/minitrace): should set local parent by @andylokandy in apache#2620
* fix(service/minitrace): update doc by @andylokandy in apache#2621
* doc(bindings/haskell): add module document by @silver-ymz in apache#2566
* docs: Update license related comments by @Prashanth-Chandra in apache#2573
* docs: add hdfs namenode High Availability related troubleshoot by @wcy-fdu in apache#2601
* docs: polish release doc by @PsiACE in apache#2608
* docs(blog): add Apache OpenDAL(Incubating): Access Data Freely by @PsiACE in apache#2607
* docs(RFC): Object Versioning by @suyanhanx in apache#2602
* ci: Disable bindings/java deploy for now by @tisonkun in apache#2560
* ci: Disable the failed stage-release job instead by @tisonkun in apache#2561
* ci: add haddock generator for haskell binding by @silver-ymz in apache#2569
* ci(binding/lua): add luarocks package manager support by @oowl in apache#2558
* build(deps): bump predicates from 2.1.5 to 3.0.1 by @dependabot in apache#2583
* build(deps): bump tower-http from 0.4.0 to 0.4.1 by @dependabot in apache#2582
* build(deps): bump chrono from 0.4.24 to 0.4.26 by @dependabot in apache#2581
* build(deps): bump redis from 0.22.3 to 0.23.0 by @dependabot in apache#2580
* build(deps): bump cbindgen from 0.24.3 to 0.24.5 by @dependabot in apache#2579
* ci: upgrade hawkeye to v3 by @tisonkun in apache#2585
* ci(services/webdav): Setup integration test for nextcloud by @Xuanwo in apache#2631
* chore: add haskell binding link to website by @silver-ymz in apache#2571
* chore: fix cargo warning for resolver by @xxchan in apache#2590
* chore: bump log to 0.4.19 by @xxchan in apache#2591
* chore(deps): update deps to latest version by @suyanhanx in apache#2596
* chore: Add release 0.38.0 to download by @PsiACE in apache#2597
* chore(service/minitrace): automatically generate span name by @andylokandy in apache#2618

* @Prashanth-Chandra made their first contribution in apache#2573
* @andylokandy made their first contribution in apache#2618

**Full Changelog**: apache/opendal@v0.38.0...v0.38.1

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@ClSlaid ClSlaid mentioned this pull request Jul 14, 2023
Xuanwo pushed a commit that referenced this pull request Jul 14, 2023
* Bump to version 0.38.1

* feat(binding/lua): add rename and create_dir operator function by @oowl in #2564
* feat(services/azblob): support sink by @suyanhanx in #2574
* feat(services/gcs): support sink by @suyanhanx in #2576
* feat(services/oss): support sink by @suyanhanx in #2577
* feat(services/obs): support sink by @suyanhanx in #2578
* feat(services/cos): impl sink by @suyanhanx in #2587
* feat(service): Support stat for Dropbox by @Zheaoli in #2588
* feat(services/dropbox): impl create_dir and polish error handling by @suyanhanx in #2600
* feat(services/dropbox): Implement refresh token support by @Xuanwo in #2604
* feat(service/dropbox): impl batch delete by @suyanhanx in #2606
* feat(CI): set Kvrocks test for service redis by @suyanhanx in #2613
* feat(core): object versioning APIs by @suyanhanx in #2614
* feat(oay): actually read configuration from `oay.toml` by @messense in #2615
* feat(services/webdav): impl sink by @suyanhanx in #2622
* feat(services/fs): impl Sink for Fs by @Ji-Xinyou in #2626
* feat(core): impl `delete_with` on blocking operator by @suyanhanx in #2633
* feat(bindings/C): add support for list in C binding by @Ji-Xinyou in #2448
* refactor(core): Add ErrorKind InvalidInput to indicate users input error by @dqhl76 in #2637
* fix(doc): fix codeblock rendering by @xxchan in #2592
* fix(service/minitrace): should set local parent by @andylokandy in #2620
* fix(service/minitrace): update doc by @andylokandy in #2621
* doc(bindings/haskell): add module document by @silver-ymz in #2566
* docs: Update license related comments by @Prashanth-Chandra in #2573
* docs: add hdfs namenode High Availability related troubleshoot by @wcy-fdu in #2601
* docs: polish release doc by @PsiACE in #2608
* docs(blog): add Apache OpenDAL(Incubating): Access Data Freely by @PsiACE in #2607
* docs(RFC): Object Versioning by @suyanhanx in #2602
* ci: Disable bindings/java deploy for now by @tisonkun in #2560
* ci: Disable the failed stage-release job instead by @tisonkun in #2561
* ci: add haddock generator for haskell binding by @silver-ymz in #2569
* ci(binding/lua): add luarocks package manager support by @oowl in #2558
* build(deps): bump predicates from 2.1.5 to 3.0.1 by @dependabot in #2583
* build(deps): bump tower-http from 0.4.0 to 0.4.1 by @dependabot in #2582
* build(deps): bump chrono from 0.4.24 to 0.4.26 by @dependabot in #2581
* build(deps): bump redis from 0.22.3 to 0.23.0 by @dependabot in #2580
* build(deps): bump cbindgen from 0.24.3 to 0.24.5 by @dependabot in #2579
* ci: upgrade hawkeye to v3 by @tisonkun in #2585
* ci(services/webdav): Setup integration test for nextcloud by @Xuanwo in #2631
* chore: add haskell binding link to website by @silver-ymz in #2571
* chore: fix cargo warning for resolver by @xxchan in #2590
* chore: bump log to 0.4.19 by @xxchan in #2591
* chore(deps): update deps to latest version by @suyanhanx in #2596
* chore: Add release 0.38.0 to download by @PsiACE in #2597
* chore(service/minitrace): automatically generate span name by @andylokandy in #2618

* @Prashanth-Chandra made their first contribution in #2573
* @andylokandy made their first contribution in #2618

**Full Changelog**: v0.38.0...v0.38.1

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>

* refactor: bump npm version

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>

* chore: include #2634

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>

---------

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants