Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-3898: Concurrent Writer #3898

Merged
merged 3 commits into from
Jan 4, 2024
Merged

RFC-3898: Concurrent Writer #3898

merged 3 commits into from
Jan 4, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 2, 2024 •
edited
Loading

Add concurrent writer RFC

Related issue

@WenyXu WenyXu mentioned this pull request Jan 2, 2024
Closed
6 tasks
@WenyXu WenyXu force-pushed the rfc/concurrent-write branch from 7d82dc2 to f2e44e5 Compare January 2, 2024 15:15
@WenyXu WenyXu force-pushed the rfc/concurrent-write branch from f2e44e5 to 4409194 Compare January 2, 2024 15:16
@WenyXu WenyXu marked this pull request as ready for review January 2, 2024 15:18
@WenyXu WenyXu requested a review from Xuanwo as a code owner January 2, 2024 15:18
Xuanwo
Xuanwo reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This RFC is great overall! But I don't like the tone to only talking about OpenDAL's Raw API (multipart upload). Users need not be aware of the multipart upload process; it is an internal detail exclusively for developers.

core/src/docs/rfcs/3898_concurrent_writer.md Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title feat: add concurrent writer RFC RFC-3898: Concurrent Writer Jan 2, 2024
@WenyXu WenyXu marked this pull request as draft January 3, 2024 09:38
@WenyXu WenyXu marked this pull request as ready for review January 3, 2024 16:11
Xuanwo
Xuanwo reviewed Jan 4, 2024
View reviewed changes
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Show resolved Hide resolved
core/src/docs/rfcs/3898_concurrent_writer.md Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft January 4, 2024 04:12
@WenyXu WenyXu marked this pull request as ready for review January 4, 2024 04:47
@WenyXu
Copy link
Member Author

WenyXu commented Jan 4, 2024

Thanks a lot, @Xuanwo. I always learn a lot when cooperating with you. Feel free to let me know if I can improve anything 🚀

Xuanwo
Xuanwo approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's move!

@Xuanwo Xuanwo merged commit 33829f4 into apache:main Jan 4, 2024
174 checks passed
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
@WenyXu WenyXu mentioned this pull request Jan 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenyXu @Xuanwo