Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't retry close if concurrent > 1 to avoid content lost #3957

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix: Don't retry close if concurrent > 1 to avoid content lost #3957

merged 2 commits into from
Jan 9, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 9, 2024

Part of #3956

@Xuanwo
Fix build
ff42b85 
Signed-off-by: Xuanwo <github@xuanwo.io>
dqhl76
dqhl76 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it is a temporary solution?

@Xuanwo
Fix
e22d82a 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 9, 2024

So, it is a temporary solution?

Yes, we need to figure how to retry the task that already in concurrent.

@Xuanwo Xuanwo merged commit 65973eb into main Jan 9, 2024
226 checks passed
@Xuanwo Xuanwo deleted the fix-concurrent branch January 9, 2024 10:13
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

@PsiACE PsiACE Awaiting requested review from PsiACE

@oowl oowl Awaiting requested review from oowl

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @dqhl76