feat(services/github): add github contents support #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Feb 28, 2024
hoslo
force-pushed
the
add-github-contents
branch
2 times, most recently
from
6188cd4
to
37aa6a7
Compare
|
@Xuanwo When disable create_dir, op.create_dir("test/") will report this error {"message":"path cannot end with a slash","errors":[{"resource":"Commit","field":"path","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/repos/contents#create-or-update-file-contents"} |
Xuanwo
reviewed
Feb 28, 2024
core/src/types/scheme.rs
Outdated
| @@ -422,6 +425,7 @@ impl From<Scheme> for &'static str { | |||
| Scheme::Postgresql => "postgresql", | |||
| Scheme::Mysql => "mysql", | |||
| Scheme::Gdrive => "gdrive", | |||
| Scheme::Github => "github_contents", | |||
Sad, let's create |
Xuanwo
changed the title
Should we remove .gitkeep from the list return？ |
Yes, we can ignore |
hoslo
force-pushed
the
add-github-contents
branch
5 times, most recently
from
acc8590
to
fbccaa2
Compare
Xuanwo
reviewed
Feb 28, 2024
hoslo
force-pushed
the
add-github-contents
branch
2 times, most recently
from
3cb04fa
to
771c40c
Compare
hoslo
force-pushed
the
add-github-contents
branch
from
771c40c
to
c90785d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part #4253