Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/surrealdb): support surrealdb service #4375

Merged
merged 4 commits into from
Mar 19, 2024
Merged

feat(services/surrealdb): support surrealdb service #4375

merged 4 commits into from
Mar 19, 2024

Conversation

yufan022
Copy link
Contributor

@yufan022 yufan022 commented Mar 15, 2024 •
edited
Loading

implemented #2753

@yufan022 yufan022 requested a review from Xuanwo as a code owner March 15, 2024 18:49
@yufan022 yufan022 changed the title feat(services/surrealdb): support surrealdb feat(services/surrealdb): support surrealdb service Mar 15, 2024
Xuanwo
Xuanwo approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, the only thing left is make clippy happy.

Thanks a lot for your work!

@Xuanwo Xuanwo merged commit 71ae6cb into apache:main Mar 19, 2024
199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yufan022 @Xuanwo