feat(bindings/java): explicit async runtime #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Mar 18, 2024
| JNIEnv::from_raw(env).expect("env must be valid") | ||
| } | ||
|
|
||
| pub enum Executor { |
There was a problem hiding this comment.
It should possibly support other runtimes. This encapsulation is lightweight and we leave the room for enhancement instead of hard code using Tokio.
tisonkun
commented
Mar 18, 2024
| } | ||
|
|
||
| impl Executor { | ||
| pub fn enter_with<F, R>(&self, f: F) -> R |
There was a problem hiding this comment.
The blocking layer should be able to decouple from Tokio also.
Perhaps using executor-trait and support passing a different executor.
Xuanwo
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support customize async executor (runtime)