Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/github): support list recursive #4423

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat(services/github): support list recursive #4423

merged 1 commit into from
Apr 26, 2024

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Apr 2, 2024

Part #4253

@hoslo hoslo requested a review from Xuanwo as a code owner April 2, 2024 05:29
@Xuanwo
Copy link
Member

Xuanwo commented Apr 3, 2024

Hi, I'm working on a refactor that might conflict with this PR. Would you like to wait me for one week?

@hoslo
Copy link
Contributor Author

hoslo commented Apr 3, 2024

Hi, I'm working on a refactor that might conflict with this PR. Would you like to wait me for one week?

Of course.

@hoslo
Copy link
Contributor Author

hoslo commented Apr 25, 2024

@Xuanwo Can this merge now?

Xuanwo
Xuanwo reviewed Apr 25, 2024
View reviewed changes
core/src/services/github/lister.rs Outdated Show resolved Hide resolved
core/src/services/github/core.rs Outdated Show resolved Hide resolved
@hoslo hoslo force-pushed the github-list-recursive branch 2 times, most recently from 5cadc80 to cabf053 Compare April 26, 2024 02:35
Xuanwo
Xuanwo reviewed Apr 26, 2024
View reviewed changes
core/src/services/github/lister.rs Outdated Show resolved Hide resolved
core/src/services/github/lister.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But github's current impl is a bit complex that hard to maintian. Can we make them better or split into two different services? Like github (based on content API) and github_tree?

@Xuanwo Xuanwo merged commit e677ba2 into main Apr 26, 2024
245 of 246 checks passed
@Xuanwo Xuanwo deleted the github-list-recursive branch April 26, 2024 07:33
@Xuanwo Xuanwo mentioned this pull request Apr 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

@Young-Flash Young-Flash Awaiting requested review from Young-Flash

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoslo @Xuanwo