Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ?Send async trait for HttpBackend when the target is wasm32 #4444

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Apr 9, 2024

Related to #3803

Applies the same pattern to HttpBackend as other Accessor implementors.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@waynexia
Copy link
Member Author

waynexia commented Apr 9, 2024

OMG it takes me 5 times to browse the CI list to find one failing task among the 200 🥲

@Xuanwo
Copy link
Member

Xuanwo commented Apr 9, 2024

Failed for ofs, let's ignore it for now.

@Xuanwo Xuanwo merged commit c969dab into apache:main Apr 9, 2024
193 of 196 checks passed
@waynexia waynexia deleted the wasm32-http-backend branch April 9, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants