Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Implement read and read_into for Reader #4467

Merged
merged 8 commits into from
Apr 11, 2024
Merged

feat(core): Implement read and read_into for Reader #4467

merged 8 commits into from
Apr 11, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 11, 2024 •
edited
Loading

Part of #4464

This PR adds Buffer based read and read_into APIs to Reader.

@Xuanwo
feat(core): Implement read and read_into for Reader
0f1859f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request Apr 11, 2024
Closed
1 task
@github-actions github-actions bot requested a review from morristai April 11, 2024 07:49
@github-actions github-actions bot requested a review from oowl April 11, 2024 07:49
@Xuanwo
Fix binding c
cb24b0e 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix binding java
684ca96 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix integration dav-server
faa533d 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix object_store
74bd00d 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix ofs
68a0d1b 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Xuanwo Xuanwo merged commit 5f6669b into main Apr 11, 2024
249 checks passed
@Xuanwo Xuanwo deleted the polish-reader branch April 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@morristai morristai Awaiting requested review from morristai

@oowl oowl Awaiting requested review from oowl

@tisonkun tisonkun Awaiting requested review from tisonkun tisonkun is a code owner

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx