feat(core): add access methods for Buffer
#4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
George-Miao
force-pushed
the
feat/buffer-accessor
branch
from
c8e35d2
to
9ee3db4
Compare
Xuanwo
reviewed
Apr 25, 2024
Xuanwo
reviewed
Apr 25, 2024
|
Mostly LGTM. The only thing left is runing code formatter. |
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new public functions for
Buffer:count, get the number ofbytes::BytesinBuffercurrent, get the current buffer, which doesn't alter any state or do any deep copy