refactor(core): Change Read's behavior to ensure it reads the exact size of data #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
changed the title
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
3 tasks
George-Miao
pushed a commit
to George-Miao/opendal
that referenced
this pull request
Jun 5, 2024
…ize of data (apache#4634) * rename limit to size Signed-off-by: Xuanwo <github@xuanwo.io> * Add buffer size check Signed-off-by: Xuanwo <github@xuanwo.io> * Polish comments Signed-off-by: Xuanwo <github@xuanwo.io> * Fix comments Signed-off-by: Xuanwo <github@xuanwo.io> * Fix blocking test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix binding c Signed-off-by: Xuanwo <github@xuanwo.io> * Fix bindings Signed-off-by: Xuanwo <github@xuanwo.io> * Fix cpp Signed-off-by: Xuanwo <github@xuanwo.io> * Fix java test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix fuzz test Signed-off-by: Xuanwo <github@xuanwo.io> * Format code Signed-off-by: Xuanwo <github@xuanwo.io> * Fix licenses Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readused to be designed to read at most bytes of data.Our users have reported that it's difficult to use because every call to
readrequires checking if the returned data meets the limit. Additionally, much of OpenDAL's internal logic relies on reading an exact number of bytes.So this PR change Read's behavior to ensure it reads the exact size of data. After this change, our users can depend on opendal's behavior instead of performing extra check.