-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init ovfs #4652
feat: init ovfs #4652
Conversation
Hi, @Xuanwo, is there anything else should be added in this PR. |
bin/ovfs/src/virtiofs.rs
Outdated
use vmm_sys_util::epoll::EventSet; | ||
use vmm_sys_util::eventfd::EventFd; | ||
|
||
const QUEUE_SIZE: usize = 32768; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide detailed descriptions for each const
so we can understand their meanings.
bin/ovfs/src/virtiofs.rs
Outdated
#[derive(Debug)] | ||
enum Error { | ||
HandleEventNotEpollIn, | ||
HandleEventUnknownEvent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error messages we provide should clarify what went wrong and guide users on how to fix the issue. Please ensure that the errors are understandable to users. Initially, we can return Unexpected(source)
.
I prefer to remove code rather than add more... 😄 Please all basic CI config like we do for opendal/.github/workflows/ci_bin_oli.yml Lines 18 to 51 in 24ced52
|
It's ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many things to polish, but I think we should give it a go.
* init ovfs * typo * add ci * unifiy error * add more comments * fix ci first * typo
Initialize ovfs project.