fix(s3): parse MultipartUploadResponse to check error in body #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
commented
Jun 14, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Xuanwo
reviewed
Jun 14, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
It seems hard to downstream users to know the actual result, the error in body is discared before this method returns. |
|
Then let's try to run a 0.47.1 release. But the unaligned version number among release artifactes is quite painful to bump ... |
|
I'm willing to run this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 may return an error when the HTTP code is 200. Like this https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_Example_4
This patch defines a
MultipartUploadResultresult which only contains error's definition. It will be deserialized on complete multipart upload's 200 result, to check if the body contains any error.For more background reference to awslabs/aws-sdk-rust#1163