Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(nodejs): Disable services-all on windows #4762

Merged
merged 1 commit into from
Jun 18, 2024
Merged

ci(nodejs): Disable services-all on windows #4762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions .github/workflows/ci_bindings_nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,13 @@ jobs:
run: cargo test --no-fail-fast

linux:
name: linux - ${{ matrix.settings.target }}
runs-on: ubuntu-latest
if: "startsWith(github.ref, 'refs/tags/')"
# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"
env:
NAPI_FEATURES: services-all
strategy:
Expand Down Expand Up @@ -129,13 +134,6 @@ jobs:
# change owner to current user
sudo chown -R 1001:121 *.node

# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"

name: linux - ${{ matrix.settings.target }}

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
Expand All @@ -161,10 +159,15 @@ jobs:
path: bindings/nodejs/*.node

windows:
name: windows - ${{ matrix.settings.target }}
runs-on: windows-latest
if: "startsWith(github.ref, 'refs/tags/')"
env:
NAPI_FEATURES: services-all

# Windows built failed with services-all
# Wait for https://github.com/apache/opendal/issues/4761
# env:
# NAPI_FEATURES: services-all

strategy:
matrix:
settings:
Expand All @@ -180,7 +183,7 @@ jobs:
run:
working-directory: "bindings/nodejs"

name: windows - ${{ matrix.settings.target }}


steps:
- uses: actions/checkout@v4
Expand All @@ -206,8 +209,13 @@ jobs:
path: bindings/nodejs/*.node

macos:
name: macos - ${{ matrix.settings.target }}
runs-on: macos-latest
if: "startsWith(github.ref, 'refs/tags/')"
# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"
env:
NAPI_FEATURES: services-all
strategy:
Expand All @@ -230,13 +238,6 @@ jobs:
pnpm build
strip -x *.node

# Notes: this defaults only apply on run tasks.
defaults:
run:
working-directory: "bindings/nodejs"

name: macos - ${{ matrix.settings.target }}

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
Expand Down