Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unftp-sbe): impl OpendalStorage #4765

Merged
merged 3 commits into from
Jun 19, 2024
Merged

feat(unftp-sbe): impl OpendalStorage #4765

merged 3 commits into from
Jun 19, 2024

Conversation

George-Miao
Copy link
Contributor

@George-Miao George-Miao commented Jun 19, 2024 •
edited
Loading

This PR adds OpendalStorage, an adapter that wraps around Operator to provide libunftp::storage::StorageBackend implementation.

@github-actions github-actions bot requested review from dqhl76 and oowl June 19, 2024 02:05
Xuanwo
Xuanwo reviewed Jun 19, 2024
View reviewed changes
integrations/unftp-sbe/src/lib.rs Outdated Show resolved Hide resolved
integrations/unftp-sbe/src/lib.rs Outdated Show resolved Hide resolved
integrations/unftp-sbe/src/lib.rs Outdated Show resolved Hide resolved
integrations/unftp-sbe/src/lib.rs Outdated Show resolved Hide resolved
integrations/unftp-sbe/src/lib.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo mentioned this pull request Jun 19, 2024
Closed
4 tasks
Xuanwo
Xuanwo approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I created a tracking issue for the remaining tasks: #4769

@Xuanwo Xuanwo merged commit 248538f into apache:main Jun 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@dqhl76 dqhl76 Awaiting requested review from dqhl76

@oowl oowl Awaiting requested review from oowl

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@George-Miao @Xuanwo