-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(services/aliyun-drive): list dir without trailing slash #4766
fix(services/aliyun-drive): list dir without trailing slash #4766
Conversation
062c64e
to
7a17b98
Compare
Hi @Xuanwo, I wonder why the PR skipped AliyunDrive CI. I can't test it lol. |
7a17b98
to
fe5aaa8
Compare
PRs from forked repo can't access our secrets for security reasons: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow |
OK. I'll close this PR and ask @suyanhanx for patch help. |
Please keep this PR open and allow @suyanhanx to open a new PR specifically for testing. I want to ensure your contributions are recognized in our repository. |
Thanks @suyanhanx for conducting the test. All checks on the Aliyun drive have now passed, let's go ahead and merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It looks good on #4767 tests. While AliyunDrive severely restricts concurrency access per account. Core-Test, Binding-Python, and Binding-Java consist of three parallel on one account leads to many retries. |
Pending.
I found that CI for AliyunDrive randomly failed. Investigating.
behavior::test_list_dir_with_recursive_no_trailing_slash