Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unftp-sbe): remove buffer for get #4775

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix(unftp-sbe): remove buffer for get #4775

merged 2 commits into from
Jun 20, 2024

Conversation

George-Miao
Copy link
Contributor

This PR returnes a tokio::io::AsyncRead instance directly instead of read everything into buffer first and then return it.

@github-actions github-actions bot requested a review from morristai June 20, 2024 06:15
Xuanwo
Xuanwo approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit b906d8a into apache:main Jun 20, 2024
24 checks passed
@George-Miao George-Miao deleted the fix/unftp-sbe-asyncread branch June 20, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@morristai morristai Awaiting requested review from morristai

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@George-Miao @Xuanwo