Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/aliyun-drive): write op cannot overwrite existing files #4781

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(services/aliyun-drive): write op cannot overwrite existing files #4781

merged 1 commit into from
Jun 21, 2024

Conversation

yuchanns
Copy link
Member

@yuchanns yuchanns commented Jun 21, 2024 •
edited
Loading

Relate to #4780.

Fix:

  • Write operation should overwrite existing files.
  • Lock while creating dir. Ensure we do not create duplicate names while concurrent access.

@yuchanns yuchanns marked this pull request as ready for review June 21, 2024 03:39
@yuchanns yuchanns requested a review from Xuanwo as a code owner June 21, 2024 03:39
@yuchanns yuchanns mentioned this pull request Jun 21, 2024
Closed
Xuanwo
Xuanwo approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit cf7580e into apache:main Jun 21, 2024
75 checks passed
@yuchanns yuchanns deleted the 4780 branch June 22, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@oowl oowl Awaiting requested review from oowl

@Young-Flash Young-Flash Awaiting requested review from Young-Flash

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuchanns @Xuanwo